[ENH] BEP032: Remove the channel_label column - #2483
Open
bendichter wants to merge 1 commit into
Open
Conversation
Remove channel_label from channels.tsv, following the working group discussion on 2026-07-29. The column was defined as a human readable identifier for specifying the content of signals not generated by electrodes, but a channel already has an identifier in the required name column, and the categories its examples gave are values of the type column. This BEP added SYNC and BEH to that enum, and SYSCLOCK, TRIG, STIM, and MISC were already there. Anything the type column does not capture belongs in description, so add a description addendum to channels.tsv pointing at that use, which is what the removed column was reaching for. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bep032-review #2483 +/- ##
==============================================
Coverage 83.09% 83.09%
==============================================
Files 22 22
Lines 1698 1698
==============================================
Hits 1411 1411
Misses 287 287 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the decision we reached in the working group meeting on 2026-07-29 about
channel_label, addressing #2307 (comment) and following up on #2307 (comment). This targetsbep032-review, so it merges into #2307 rather than into master.The Change
channel_labelis removed fromchannels.tsv. The column was defined as a human readable identifier for specifying the content of signals not generated by electrodes, but a channel already has an identifier in the requirednamecolumn, and the categories its examples gave are values of thetypecolumn. This BEP addedSYNCandBEHto that enum, andSYSCLOCK,TRIG,STIM, andMISCwere there already.Anything the
typecolumn does not capture belongs indescription, so rather than deleting the column and leaving nothing in its place, this adds a description addendum tochannels.tsvpointing at that use:The example phrasing there is deliberate. @lzehl made the point in the meeting that
behavioral signalsandbehavioral cues, the examples the removed column carried, are terms rather than descriptions, so the addendum shows a description that actually describes something.Scope
This is a small change.
channel_labelappeared only inobjects/columns.yamland themicroephysChannelsrule, and was not used in any example table or referenced in any prose, so nothing else needed updating.Verification
bidsschematoolstests pass (81 passed, 1 skipped), as dopre-commiton the changed files andnpm run remark. I confirmed no references tochannel_labelremain anywhere insrc/, and that the rendered channels table now carries the addendum ondescription.@lzehl, this is the fourth item from the meeting. The others are #2480, #2481, and #2482.