Fix PHPStan violations: add missing type annotations, remove unused closure variable, fix \string[] return type#42
Draft
Fix PHPStan violations: add missing type annotations, remove unused closure variable, fix \string[] return type#42
Conversation
TomA-R
force-pushed
the
phpstan_violations
branch
from
b7453fd to
4539676
Compare
…losure variable, fix \string[] return type
TomA-R
force-pushed
the
phpstan_violations
branch
from
4539676 to
6444d5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolve 26 of 30 PHPStan baseline violations by adding missing iterable/generic type annotations, fixing the \string[] return type on getAutoCreateWhiteList(), and removing an unused $className closure variable in BindingClosureFactory.
4 remaining entries are external library type mismatches (ProxyManager) or PHPStan template resolution limits — not worth contorting code to fix.
Tickets / Documentation
n/a