fix(known-hosts): filter out public service hosts from scan/import#2500
Merged
binaricat merged 1 commit intoJul 26, 2026
Merged
Conversation
When scanning the system known_hosts file or importing from a file, exclude well-known public service hostnames (github.com, gitlab.com, bitbucket.org, Azure DevOps) from being added to the Known Hosts vault. These entries represent third-party services rather than user-managed hosts and are not meaningful in an SSH host management context. - Add PUBLIC_SERVICE_HOSTNAMES exclusion list - Apply filter in both system scan and file import paths - Show a toast notification when entries are filtered - Add locale strings for filtered count (en, zh-CN, zh-TW, ru)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When scanning the system known_hosts file or importing from a file, well-known public service hostnames (e.g. github.com, gitlab.com) are now excluded from being added to the Known Hosts vault.
Changes
Before
Scanning system known_hosts would import github.com, gitlab.com, etc. into the vault.
After
Public service hostnames are filtered out, and a toast shows how many were skipped.