refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access#28391

Merged

fanquake merged 15 commits into

bitcoin:masterfrom

sedited:simplifyMemPoolInteractions

Nov 13, 2023

Commits on Nov 10, 2023

[refactor] Add helper for iterating through mempool entries

stickies-v
authored and
sedited
committed
[refactor] Add helper for retrieving mempool entry
sedited
committed
[refactor] remove access to mapTx from policy/rbf.cpp

glozow
authored and
sedited
committed
[refactor] use exists() instead of mapTx.find()

glozow
authored and
sedited
committed
[refactor] get wtxid from entry instead of vTxHashes

glozow
authored and
sedited
committed
[refactor] remove access to mapTx from rpc/mempool.cpp

glozow
authored and
sedited
committed
[refactor] remove access to mapTx in blockencodings_tests.cpp

glozow
authored and
sedited
committed
[refactor] remove access to mapTx.find in mempool_tests.cpp

glozow
authored and
sedited
committed
[refactor] use CheckPackageLimits for checkChainLimits

glozow
authored and
sedited
committed
[txmempool] make CTxMemPoolEntry::lockPoints mutable

glozow
authored and
sedited
committed
[refactor] remove access to mapTx in validation.cpp

glozow
authored and
sedited
committed
[refactor] rewrite vTxHashes as a vector of CTransactionRef

glozow
authored and
sedited
committed
scripted-diff: rename vTxHashes to txns_randomized
sedited
committed
[refactor] rewrite BlockAssembler inBlock and failedTx as sets of txids

glozow
authored and
sedited
committed
[refactor] remove access to mapTx in validation_block_tests
sedited
committed