Introduce per-input sighash type via Input::set_sighash_type#69
Open
evanlinjin wants to merge 1 commit into
Open
Introduce per-input sighash type via Input::set_sighash_type#69evanlinjin wants to merge 1 commit into
Input::set_sighash_type#69evanlinjin wants to merge 1 commit into
Conversation
evanlinjin
force-pushed
the
feature/per-input-sighash-type
branch
3 times, most recently
from
556f0e1 to
9ffb42c
Compare
noahjoeris
approved these changes
May 16, 2026
Contributor
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
Nice one!
ACK 9ffb42c
Replace `PsbtParams::sighash_type` with a per-input setter/getter on `Input`. `Selection::create_psbt` propagates each input's sighash type into the resulting PSBT input. `Input::set_sighash_type` accepts anything convertible into `PsbtSighashType`, including the standard `EcdsaSighashType` and `TapSighashType` from rust-bitcoin. BREAKING CHANGE: `PsbtParams::sighash_type` is removed. Callers should call `Input::set_sighash_type` on each input before selection.
evanlinjin
force-pushed
the
feature/per-input-sighash-type
branch
from
9ffb42c to
95d4b35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #60
Replace
PsbtParams::sighash_typewith a per-input setter/getter onInput.Selection::create_psbtpropagates each input's sighash type into the resulting PSBT input.Changelog notice
Before submitting