Skip to content

[PM-37255] feat: Integrate fill-assist targeting rules into autofill parser#7066

Open
aj-rosado wants to merge 24 commits into
mainfrom
PM-37256/apply-fill-assist-rules
Open

[PM-37255] feat: Integrate fill-assist targeting rules into autofill parser#7066
aj-rosado wants to merge 24 commits into
mainfrom
PM-37256/apply-fill-assist-rules

Merge branch 'PM-37255/fill-assist-integration' into PM-37256/apply-f…

02f1319
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 29, 2026 in 41s

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.4% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 385 in app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/util/FillAssistViewNodeExtensionsTest.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this function so that its implementation is not identical to "buildFillAssistViews should not match when htmlInfo tag differs from clause tag" on line 308. 

See more on https://sonarcloud.io/project/issues?id=bitwarden_android&issues=AZ7QRo7HKIouttz3uf2Q&open=AZ7QRo7HKIouttz3uf2Q&pullRequest=7066

Check warning on line 146 in app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/util/FillAssistViewNodeExtensionsTest.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 22 lines of code, which is greater than the 20 authorized. Split it into smaller functions. 

See more on https://sonarcloud.io/project/issues?id=bitwarden_android&issues=AZ7QRo7HKIouttz3uf2S&open=AZ7QRo7HKIouttz3uf2S&pullRequest=7066

Check failure on line 90 in app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/util/FillAssistViewNodeExtensionsTest.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "account-login" 7 times. 

See more on https://sonarcloud.io/project/issues?id=bitwarden_android&issues=AZ7QRo7HKIouttz3uf2T&open=AZ7QRo7HKIouttz3uf2T&pullRequest=7066

Check warning on line 461 in app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/util/FillAssistViewNodeExtensionsTest.kt

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this function so that its implementation is not identical to "buildFillAssistViews should match when htmlInfo has correct id attribute" on line 369. 

See more on https://sonarcloud.io/project/issues?id=bitwarden_android&issues=AZ7QRo7HKIouttz3uf2R&open=AZ7QRo7HKIouttz3uf2R&pullRequest=7066
View more details on SonarQubeCloud