Skip to content

PM-35112: feat: Add underlying FedRAMP environment#7138

Open
david-livefront wants to merge 1 commit into
mainfrom
PM-35112-fed-ramp-environment
Open

PM-35112: feat: Add underlying FedRAMP environment#7138
david-livefront wants to merge 1 commit into
mainfrom
PM-35112-fed-ramp-environment

Conversation

@david-livefront

@david-livefront david-livefront commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-35112

📔 Objective

This PR adds the FedRAMP environment to the underlying structures of the app and integrates it into the LandingScreen UI.

The UI changes are currently feature flagged.

📸 Screenshots

Screen_recording_20260702_145555.mp4

@david-livefront david-livefront requested a review from a team as a code owner July 2, 2026 19:56
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Jul 2, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the addition of the FedRAMP environment across the data models (Environment, EnvironmentRegion, EnvironmentUrlDataJson) and its feature-flagged integration into the landing screen. All when branches on the Environment sealed class and EnvironmentRegion/Environment.Type enums are exhaustively handled (compiler-enforced), account creation is correctly disabled for FedRAMP, and each new branch has matching unit test coverage. No security, correctness, or breaking-change issues were found.

Code Review Details

No blocking findings.

Notes:

  • The existing unresolved thread on EnvironmentUrlDataJson.kt:113 references a KDoc copy-paste error ("US region"). The current code reads "Default [EnvironmentUrlDataJson] for the FedRAMP environment." which is correct, so no further action is needed.
  • FedRAMP is gated by FlagKey.FedRamp in LandingState.environmentTypeOptions but filtered unconditionally in StartRegistrationState — this is consistent with account creation being unsupported on FedRAMP.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.17%. Comparing base (3ece24b) to head (b513bcb).

Files with missing lines Patch % Lines
...epository/util/EnvironmentUrlDataJsonExtensions.kt 25.00% 6 Missing ⚠️
...i/auth/feature/environment/EnvironmentViewModel.kt 0.00% 0 Missing and 1 partial ⚠️
...warden/ui/auth/feature/landing/LandingViewModel.kt 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7138      +/-   ##
==========================================
+ Coverage   85.60%   86.17%   +0.57%     
==========================================
  Files         910      882      -28     
  Lines       65397    64392    -1005     
  Branches     9592     9588       -4     
==========================================
- Hits        55986    55493     -493     
+ Misses       5967     5456     -511     
+ Partials     3444     3443       -1     
Flag Coverage Δ
app-data 17.60% <7.40%> (+0.29%) ⬆️
app-ui-auth-tools 18.80% <74.07%> (+0.17%) ⬆️
app-ui-platform 16.48% <1.85%> (-0.33%) ⬇️
app-ui-vault 27.50% <0.00%> (-0.02%) ⬇️
authenticator 6.16% <0.00%> (+<0.01%) ⬆️
lib-core-network-bridge 4.05% <0.00%> (-0.01%) ⬇️
lib-data-ui 1.14% <3.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront david-livefront force-pushed the PM-35112-fed-ramp-environment branch from 96d0c70 to dda6cee Compare July 2, 2026 20:08
@david-livefront david-livefront force-pushed the PM-35112-fed-ramp-environment branch from dda6cee to b513bcb Compare July 2, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant