[PM-40133] feat: Add Send Controls policy support and AnyCodable array/dictionary decoding#2868
[PM-40133] feat: Add Send Controls policy support and AnyCodable array/dictionary decoding#2868matt-livefront wants to merge 3 commits into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the Send Controls policy plumbing ( Code Review DetailsNo new findings. The feature flag is placed alphabetically in both the declaration and |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
==========================================
- Coverage 81.27% 78.98% -2.30%
==========================================
Files 1027 1150 +123
Lines 66109 73426 +7317
==========================================
+ Hits 53733 57993 +4260
- Misses 12376 15433 +3057 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
PM-40133
📔 Objective
Adds the new Send Controls policy and feature flag. This also fixes a JSON decoding error for the policy since we didn't previously have
AnyCodablesupport for array types.PolicyType.sendControls(raw value21) and completes its bidirectional SDK mapping inPolicyService+SdkMapping.swift.pm-31885-send-controlsfeature flag to theFeatureFlagcatalog (no client-side gating call site yet — this pass is plumbing only).AnyCodablegains array (case array([AnyCodable])) and object/dictionary (case dictionary([String: AnyCodable])) support, so it now covers every JSON value kind. A policydatafield containing a JSON array (e.g. Send Controls'allowedSendTypes) or a nested object no longer throwsDecodingError.dataCorruptedError.