-
Notifications
You must be signed in to change notification settings - Fork 137
[PM-33981] feat: Add device management UI and Account Security integration #2871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrebispo5
wants to merge
8
commits into
pm-33981/device-table-core
Choose a base branch
from
pm-33981/device-table-ui
base: pm-33981/device-table-core
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a0d94bf
[PM-33981] feat: Add device management UI and Account Security integr…
andrebispo5 8017042
[PM-33981] fix: Set correct dark mode colors for info and warning pil…
andrebispo5 c5077d0
[PM-33981] fix: Set dark mode colors for success and danger pill badges
andrebispo5 9a603ad
[PM-33981] fix: Address Copilot review comments
andrebispo5 d8091fe
[PM-33981] fix: Sync ServiceContainer+Mocks backward compat fix from …
andrebispo5 e811124
[PM-33981] fix: Revert pendingRequestMatchKey — server sends same req…
andrebispo5 0b1390f
[PM-33981] fix: Address PR review comments on device management
andrebispo5 fd7737e
Merge branch 'pm-33981/device-table-core' into pm-33981/device-table-ui
andrebispo5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 23 additions & 23 deletions
46
BitwardenResources/Colors.xcassets/Badge/badgeDangerBackground.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| "colors": [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xF2", | ||
| "green" : "0xF2", | ||
| "red" : "0xFE" | ||
| "color": { | ||
| "color-space": "srgb", | ||
| "components": { | ||
| "alpha": "1.000", | ||
| "blue": "0xF2", | ||
| "green": "0xF2", | ||
| "red": "0xFE" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| "idiom": "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| "appearances": [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| "appearance": "luminosity", | ||
| "value": "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xF2", | ||
| "green" : "0xF2", | ||
| "red" : "0xFE" | ||
| "color": { | ||
| "color-space": "srgb", | ||
| "components": { | ||
| "alpha": "1.000", | ||
| "blue": "0x09", | ||
| "green": "0x08", | ||
| "red": "0x46" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| "idiom": "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| "info": { | ||
| "author": "xcode", | ||
| "version": 1 | ||
| } | ||
| } | ||
46 changes: 23 additions & 23 deletions
46
BitwardenResources/Colors.xcassets/Badge/badgeDangerBorder.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| "colors": [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xC9", | ||
| "green" : "0xC9", | ||
| "red" : "0xFF" | ||
| "color": { | ||
| "color-space": "srgb", | ||
| "components": { | ||
| "alpha": "1.000", | ||
| "blue": "0xC9", | ||
| "green": "0xC9", | ||
| "red": "0xFF" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| "idiom": "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| "appearances": [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| "appearance": "luminosity", | ||
| "value": "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xC9", | ||
| "green" : "0xC9", | ||
| "red" : "0xFF" | ||
| "color": { | ||
| "color-space": "srgb", | ||
| "components": { | ||
| "alpha": "1.000", | ||
| "blue": "0x12", | ||
| "green": "0x07", | ||
| "red": "0x9F" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| "idiom": "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| "info": { | ||
| "author": "xcode", | ||
| "version": 1 | ||
| } | ||
| } |
46 changes: 23 additions & 23 deletions
46
BitwardenResources/Colors.xcassets/Badge/badgeDangerText.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| "colors": [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0x2A", | ||
| "green" : "0x1B", | ||
| "red" : "0x95" | ||
| "color": { | ||
| "color-space": "srgb", | ||
| "components": { | ||
| "alpha": "1.000", | ||
| "blue": "0x2A", | ||
| "green": "0x1B", | ||
| "red": "0x95" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| "idiom": "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| "appearances": [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| "appearance": "luminosity", | ||
| "value": "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0x2A", | ||
| "green" : "0x1B", | ||
| "red" : "0x95" | ||
| "color": { | ||
| "color-space": "srgb", | ||
| "components": { | ||
| "alpha": "1.000", | ||
| "blue": "0xC9", | ||
| "green": "0xC9", | ||
| "red": "0xFF" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| "idiom": "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| "info": { | ||
| "author": "xcode", | ||
| "version": 1 | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
BitwardenResources/Colors.xcassets/Badge/badgeInfoBackground.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xFF", | ||
| "green" : "0xF6", | ||
| "red" : "0xEE" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0x55", | ||
| "green" : "0x24", | ||
| "red" : "0x16" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
BitwardenResources/Colors.xcassets/Badge/badgeInfoBorder.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xFF", | ||
| "green" : "0xDB", | ||
| "red" : "0xBE" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xAC", | ||
| "green" : "0x41", | ||
| "red" : "0x1A" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
BitwardenResources/Colors.xcassets/Badge/badgeInfoText.colorset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "colors" : [ | ||
| { | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xAC", | ||
| "green" : "0x41", | ||
| "red" : "0x1A" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| }, | ||
| { | ||
| "appearances" : [ | ||
| { | ||
| "appearance" : "luminosity", | ||
| "value" : "dark" | ||
| } | ||
| ], | ||
| "color" : { | ||
| "color-space" : "srgb", | ||
| "components" : { | ||
| "alpha" : "1.000", | ||
| "blue" : "0xF6", | ||
| "green" : "0xE5", | ||
| "red" : "0xDB" | ||
| } | ||
| }, | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Any idea why this format changed? Is this Xcode changing this?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've normalized the spacing back to match the repo convention across all the affected files (danger + success) so the diff only shows the actual color value changes.