Skip to content

[PM-40163] fix: Update text for TOTP Login premium alert.#2881

Merged
morganzellers-bw merged 4 commits into
mainfrom
pm-40163-update-totp-premium-upgrade-alert-copy
Jul 15, 2026
Merged

[PM-40163] fix: Update text for TOTP Login premium alert.#2881
morganzellers-bw merged 4 commits into
mainfrom
pm-40163-update-totp-premium-upgrade-alert-copy

Conversation

@morganzellers-bw

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40163

📔 Objective

Update the text in the alert that notifies the user that TOTP codes are a Premium feature.

📸 Screenshots

Click to reveal premiumTOTPAfterChange

@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:bug Change Type - Bug labels Jul 13, 2026
@morganzellers-bw morganzellers-bw marked this pull request as ready for review July 13, 2026 16:24
@morganzellers-bw morganzellers-bw requested review from a team and matt-livefront as code owners July 13, 2026 16:24
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR updates the TOTP premium-required alert to use a new, more descriptive message (PremiumRequiredTOTPDescriptionLong) in Alert.totpPremiumRequired. A new localization key is added to en.lproj/Localizable.strings, and both affected tests (AlertVaultTests.swift and ViewItemProcessorTests.swift) are updated to assert the new string, resolving the earlier CI-failure concern. Only the English strings file was edited, consistent with Bitwarden's Crowdin-managed translation workflow.

No security, correctness, or breaking-change concerns were found.

@morganzellers-bw morganzellers-bw marked this pull request as draft July 13, 2026 16:29
@morganzellers-bw morganzellers-bw marked this pull request as ready for review July 13, 2026 16:38
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.97%. Comparing base (76731fd) to head (6adc327).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
- Coverage   81.25%   78.97%   -2.28%     
==========================================
  Files        1028     1151     +123     
  Lines       66164    73459    +7295     
==========================================
+ Hits        53759    58014    +4255     
- Misses      12405    15445    +3040     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morganzellers-bw morganzellers-bw merged commit 3b93b7b into main Jul 15, 2026
18 checks passed
@morganzellers-bw morganzellers-bw deleted the pm-40163-update-totp-premium-upgrade-alert-copy branch July 15, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants