H08: Create chart with separate axes and custom svg elements#11
Open
dqmrf wants to merge 5 commits into
Open
Conversation
ddragula
approved these changes
Jun 29, 2026
ddragula
left a comment
ddragula
left a comment
Member
There was a problem hiding this comment.
LGTM 🎉
PS Just out of curiosity, I wonder where the idea for what I saw in previous commits came from (the extensive inheritance of specific SVG Element classes). 😄 Impressive, but quite complex for such a simple task.
Comment on lines
+140
to
+141
| enableMouseTracking: false, | ||
| states: { hover: { enabled: false } } |
Member
There was a problem hiding this comment.
You don't need to disable hover state if you also disable mouse tracking.
Collaborator
Author
|
In the previous commit, I was just playing around with prototypes, then rewrote it all into classes. But yes, this is not for this case, and especially not for the demo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.