feat(tornado): Proposal 67 malicious-proposal verification#89
Open
Zeugh-eth wants to merge 2 commits into
Open
feat(tornado): Proposal 67 malicious-proposal verification#89Zeugh-eth wants to merge 2 commits into
Zeugh-eth wants to merge 2 commits into
Conversation
Proposal 67 disguises a counterfeit Relayer Registry as a fee/burn change. Its target redirects governance()/staking() to attacker vanity look-alikes, gating nullifyBalance() to the attacker (relayer kill-switch). Adds fork tests verifying the spoofed addresses, the attacker capability matrix, and that the treasury is unreachable by the attacker yet drainable by the real proxy. Plus a human-readable audit.html and README. Tests fork mainnet and need a non-censoring MAINNET_RPC_URL (OFAC).
5 tasks
Make Tornado Cash a first-class DAO in the harness: - src/tornado/Constants.sol, interfaces (ITornadoGovernance, IRelayerRegistry) - src/tornado/tornado.t.sol: Tornado_Base (fork/labels/lock helper) and Tornado_Governance, which runs the real custom-governor lifecycle (lock -> propose -> castVote(bool) -> execute) with before/after hooks. Includes a MockProposal lifecycle self-test that passes end-to-end on a mainnet fork (proves legit proposals can be verified). - dao-registry.json + @tornado/ remapping entries. - Refactor Proposal 67 verification onto Tornado_Base. 8 tests pass (1 lifecycle + 7 Proposal-67) forking at head; pinned-block runs need a non-censoring archive MAINNET_RPC_URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Foundry verification of Tornado Cash Proposal 67 — a live malicious proposal — under
src/tornado/proposals/67/.Proposal 67 is disguised as a relayer-fee + token-burn change. Its target is an unverified, counterfeit Relayer Registry whose
governance()/staking()resolve to attacker-controlled vanity look-alike addresses, gatingnullifyBalance()to the attacker (a relayer kill-switch). It is an attack on the protocol, not the treasury.Contents
proposal67.t.sol— 7 fork tests across 3 suites:governance()/staking()are vanity look-alikes (share the 7-byte prefix, ≠ real)nullifyBalance; the real DAO governance is locked outREADME.md— summary + Etherscan references + run instructionsaudit.html— human-readable security reportVerification
Verified locally forking at chain head via a non-censoring RPC (publicnode). The committed test pins block⚠️ Several public RPCs (llamarpc, cloudflare) block Tornado Cash calls (OFAC) — a non-censoring endpoint is required.
25_427_000, which (like the other proposal tests here) needs an archiveMAINNET_RPC_URL.Notes / follow-up
Tornado_Governancebase +dao-registry.jsonentry (via thedao-scaffoldpattern) is a sensible follow-up if Tornado becomes a first-class supported DAO here.