Improve connection reliability: logging, timeouts, and error handling#3194
Closed
gfrmin wants to merge 1 commit into
Closed
Improve connection reliability: logging, timeouts, and error handling#3194gfrmin wants to merge 1 commit into
gfrmin wants to merge 1 commit into
Conversation
- Log AutoConnect failures instead of silently swallowing them - Replace GLib.MAXINT D-Bus timeout with 45s to prevent UI freeze - Guard double-click connect against duplicate operations - Add 60s auto-clear for stuck operations in ManagerDeviceMenu - Handle malformed error messages in parse_dbus_error Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoConnect.err()silently discarded failures withpass. Now logs warnings so users/devs can see why auto-connect failed.timeout=GLib.MAXINTwith 45s onConnectService/DisconnectServicecalls. Prevents indefinite UI freeze when BlueZ hangs (related: blueman-manager 2.4.1 freezes on Debian 13 #2927).ManagerDeviceMenu.__ops__are now auto-cleared after 60 seconds, preventing the permanent "Connecting..." state.parse_dbus_error: AddedValueErrorhandling for malformed D-Bus error messages that don't contain the expected colon-separated format.Note on related PRs
This PR intentionally does not touch the error message mapping in
_handle_error_message/_BLUEZ_ERROR_MAP, as that area is being improved by #3120 and #2556.Test plan
AutoConnectfailures appear in log outputpython -m py_compilepasses on all 4 modified files🤖 Generated with Claude Code