AutoConnect: Log failed auto-connect attempts#3204
Open
gfrmin wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@cschramm this looks fine to me but I don't remember if there was a reason this wasn't logged before. Maybe to spammy as it's every 60(ish) seconds? |
Auto-connect retries every ~60s, so a permanently-unreachable device would otherwise emit a warning line every minute forever. Track the last error reason per device address; log only when the reason changes. Clear the entry on a successful connect so a later failure logs again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error callback in
AutoConnect._runcurrently swallows failures silently withpass, so users get no feedback when the 60-second auto-connect loop can't reach a configured device.Log the failure at warning level with the device name and reason so it surfaces in the journal/console.