errors: Handle malformed messages in parse_dbus_error#3206
Open
gfrmin wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
infirit
approved these changes
Apr 18, 2026
Contributor
infirit
left a comment
There was a problem hiding this comment.
The mypy errors are unrelated so feel free to ignore them until we fixed them in main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



parse_dbus_errorassumes the exception message always has the formgerror:dbus_error:messageand does an uncheckedsplit(':', 2)unpack. If BlueZ (or a proxy/glib path) ever produces a message with fewer colons, this raisesValueErrorfrom inside the error handler itself, masking the original failure.Wrap the split in try/except and fall back to returning a plain
BluezDBusExceptionwith the raw message.