[PW_SID:1094429] Bluetooth: hci_core: Don't queue tx_work while draining workqueue#185
[PW_SID:1094429] Bluetooth: hci_core: Don't queue tx_work while draining workqueue#185BluezTestBot wants to merge 6 commits into
Conversation
This patch adds workflow files for ci: [sync.yml] - The workflow file for scheduled work - Sync the repo with upstream repo and rebase the workflow branch - Review the patches in the patchwork and creates the PR if needed [ci.yml] - The workflow file for CI tasks - Run CI tests when PR is created Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
This replaces the bzcafe action with bluez/action-ci so we can maintain everything in the github bluez organization Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This attempts to sync every 5 minutes instead of 30. Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
bluez/action-ci uses master as default branch for workflow which is incorrect for kernel Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The CI action now creates individual GitHub Check Runs per test, which requires 'checks: write' permission on the GITHUB_TOKEN. Also make the pull_request trigger types explicit to include 'reopened', allowing CI to be retriggered by closing and reopening a PR.
Syzbot reported a warning when L2CAP calls queue_work() on the hdev workqueue while it's being drained. This can happen during device reset or close paths for hci_send_acl(), hci_send_sco() and hci_send_iso(). The workqueue is drained in hci_dev_do_reset() and in hci_dev_close_sync(): - hci_dev_close_sync() clears the HCI_UP bit before draining - hci_dev_do_reset() sets HCI_CMD_DRAIN_WORKQUEUE before draining Add these checks before queuing tx_work, and free the SKB if it's not queued for transmission. Fixes: 3eff45e ("Bluetooth: convert tx_task to workqueue") Reported-by: syzbot+97721dd81f792e838ba0@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=97721dd81f792e838ba0 Signed-off-by: Heitor Alves de Siqueira <halves@igalia.com>
|
CheckPatch |
|
GitLint |
|
SubjectPrefix |
|
BuildKernel |
|
CheckAllWarning |
|
CheckSparse |
|
BuildKernel32 |
|
TestRunnerSetup |
|
TestRunner_l2cap-tester |
|
TestRunner_iso-tester |
|
TestRunner_bnep-tester |
|
TestRunner_mgmt-tester |
|
TestRunner_rfcomm-tester |
|
TestRunner_sco-tester |
|
TestRunner_ioctl-tester |
|
TestRunner_mesh-tester |
|
TestRunner_smp-tester |
|
TestRunner_userchan-tester |
|
TestRunner_6lowpan-tester |
|
IncrementalBuild |
github-actions
Bot
force-pushed
the
workflow
branch
from
e6b705e to
133f77d
Compare
4 participants
Syzbot reported a warning when L2CAP calls queue_work() on the hdev
workqueue while it's being drained. This can happen during device reset or
close paths for hci_send_acl(), hci_send_sco() and hci_send_iso().
The workqueue is drained in hci_dev_do_reset() and in hci_dev_close_sync():
Add these checks before queuing tx_work, and free the SKB if it's not
queued for transmission.
Fixes: 3eff45e ("Bluetooth: convert tx_task to workqueue")
Reported-by: syzbot+97721dd81f792e838ba0@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=97721dd81f792e838ba0
Signed-off-by: Heitor Alves de Siqueira halves@igalia.com
net/bluetooth/hci_core.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
base-commit: 1f63dd8ca0dc05a8272bb8155f643c691d29bb11
change-id: 20260513-hci_send-640290de7acc
Best regards,
Heitor Alves de Siqueira halves@igalia.com