[PW_SID:1094450] [v2] Bluetooth: btusb: clear remote wake on idle Intel ACPI paths#186
Open
BluezTestBot wants to merge 6 commits into
Open
[PW_SID:1094450] [v2] Bluetooth: btusb: clear remote wake on idle Intel ACPI paths#186BluezTestBot wants to merge 6 commits into
BluezTestBot wants to merge 6 commits into
Conversation
This patch adds workflow files for ci: [sync.yml] - The workflow file for scheduled work - Sync the repo with upstream repo and rebase the workflow branch - Review the patches in the patchwork and creates the PR if needed [ci.yml] - The workflow file for CI tasks - Run CI tests when PR is created Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
This replaces the bzcafe action with bluez/action-ci so we can maintain everything in the github bluez organization Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This attempts to sync every 5 minutes instead of 30. Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
bluez/action-ci uses master as default branch for workflow which is incorrect for kernel Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The CI action now creates individual GitHub Check Runs per test, which requires 'checks: write' permission on the GITHUB_TOKEN. Also make the pull_request trigger types explicit to include 'reopened', allowing CI to be retriggered by closing and reopening a PR.
Commit 8020c41 ("usb: core: allow ACPI-managed hard-wired ports to power off") allows internal USB devices on ACPI-managed hard-wired ports to use the existing runtime power-off path. For Intel combined USB Bluetooth controllers, btusb still keeps runtime remote wake enabled for as long as the adapter is open, which prevents the USB PM core from dropping the last child reference and powering the port off while idle. Only keep runtime remote wake enabled while the controller is expected to signal activity on its own: established links, discovery, LE scan, LE advertising, or BR/EDR page/inquiry scan. When those are idle, clear needs_remote_wakeup so autosuspend can power-manage the port and a later host-initiated command can resume the device again. Cache the BTUSB_INTEL_COMBINED match flag in btusb_data so the runtime wake decision can be made from the open and receive paths, where the usb_device_id used during probe is no longer available. Signed-off-by: Sean Rhodes <sean@starlabs.systems>
|
CheckPatch |
|
GitLint |
|
SubjectPrefix |
|
BuildKernel |
|
CheckAllWarning |
|
CheckSparse |
|
BuildKernel32 |
|
TestRunnerSetup |
|
IncrementalBuild |
github-actions
Bot
force-pushed
the
workflow
branch
from
e6b705e to
133f77d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 8020c41 ("usb: core: allow ACPI-managed hard-wired ports
to power off") allows internal USB devices on ACPI-managed hard-wired
ports to use the existing runtime power-off path. For Intel combined USB
Bluetooth controllers, btusb still keeps runtime remote wake enabled for
as long as the adapter is open, which prevents the USB PM core from
dropping the last child reference and powering the port off while idle.
Only keep runtime remote wake enabled while the controller is expected
to signal activity on its own: established links, discovery, LE scan,
LE advertising, or BR/EDR page/inquiry scan. When those are idle, clear
needs_remote_wakeup so autosuspend can power-manage the port and a later
host-initiated command can resume the device again.
Cache the BTUSB_INTEL_COMBINED match flag in btusb_data so the runtime
wake decision can be made from the open and receive paths, where the
usb_device_id used during probe is no longer available.
Signed-off-by: Sean Rhodes sean@starlabs.systems
drivers/bluetooth/btusb.c | 50 +++++++++++++++++++++++++++++++++++++--
1 file changed, 48 insertions(+), 2 deletions(-)