Skip to content

[PW_SID:1095975] [v3] Bluetooth: btintel: Use skb_pull_data return for bounds check #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BluezTestBot wants to merge 6 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:1095975] [v3] Bluetooth: btintel: Use skb_pull_data return for bounds check #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
233c3f2
workflow: Add workflow files for ci
tedd-an Nov 5, 2020
e8329bd
workflows: Make use bluez/action-ci action
Vudentz Apr 9, 2026
21607fe
workflow/sync: Attempt to sync every 5 minutes
Vudentz Apr 9, 2026
cc49aee
workflow/sync: Set workflow to use worflow branch
Vudentz Apr 9, 2026
b227437
workflow/ci: Add checks:write permission and explicit reopened trigger
Vudentz Apr 13, 2026
1b725bd
Bluetooth: btintel: Use skb_pull_data return for bounds check
enlist12 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: CI

on:
pull_request:
types: [opened, synchronize, reopened]

permissions:
checks: write
pull-requests: write

jobs:
ci:
runs-on: ubuntu-latest
name: CI for Pull Request
steps:
- name: Checkout the source code
uses: actions/checkout@v3
with:
path: src/src

- name: CI
uses: bluez/action-ci@main
with:
task: ci
base_folder: src
space: kernel
github_token: ${{ secrets.GITHUB_TOKEN }}
email_token: ${{ secrets.EMAIL_TOKEN }}
patchwork_token: ${{ secrets.PATCHWORK_TOKEN }}
patchwork_user: ${{ secrets.PATCHWORK_USER }}

44 changes: 44 additions & 0 deletions .github/workflows/sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Sync

on:
schedule:
- cron: "*/5 * * * *"

jobs:
sync_repo:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
ref: master

- name: Sync Repo
uses: bluez/action-ci@main
with:
task: sync
workflow: workflow
upstream_repo: 'https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git'
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Cleanup PR
uses: bluez/action-ci@main
with:
task: cleanup
github_token: ${{ secrets.ACTION_TOKEN }}

sync_patchwork:
needs: sync_repo
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Sync Patchwork
uses: bluez/action-ci@main
with:
task: patchwork
workflow: workflow
space: kernel
github_token: ${{ secrets.ACTION_TOKEN }}
email_token: ${{ secrets.EMAIL_TOKEN }}
patchwork_token: ${{ secrets.PATCHWORK_TOKEN }}
patchwork_user: ${{ secrets.PATCHWORK_USER }}
106 changes: 79 additions & 27 deletions drivers/bluetooth/btintel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3358,21 +3358,18 @@ void btintel_print_fseq_info(struct hci_dev *hdev)
return;
}

if (skb->len < (sizeof(u32) * 16 + 2)) {
bt_dev_dbg(hdev, "Malformed packet of length %u received",
skb->len);
kfree_skb(skb);
return;
}

p = skb_pull_data(skb, 1);
if (!p)
goto malformed;
if (*p) {
bt_dev_dbg(hdev, "Failed to get fseq status (0x%2.2x)", *p);
kfree_skb(skb);
return;
}

p = skb_pull_data(skb, 1);
if (!p)
goto malformed;
switch (*p) {
case 0:
str = "Success";
Expand All @@ -3396,65 +3393,120 @@ void btintel_print_fseq_info(struct hci_dev *hdev)

bt_dev_info(hdev, "Fseq status: %s (0x%2.2x)", str, *p);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Reason: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Global version: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Installed version: 0x%8.8x", val);

p = skb->data;
skb_pull_data(skb, 4);
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
bt_dev_info(hdev, "Fseq executed: %2.2u.%2.2u.%2.2u.%2.2u", p[0], p[1],
p[2], p[3]);

p = skb->data;
skb_pull_data(skb, 4);
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
bt_dev_info(hdev, "Fseq BT Top: %2.2u.%2.2u.%2.2u.%2.2u", p[0], p[1],
p[2], p[3]);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq Top init version: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq Cnvio init version: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq MBX Wifi file version: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq BT version: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq Top reset address: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq MBX timeout: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq MBX ack: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq CNVi id: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq CNVr id: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq Error handle: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq Magic noalive indication: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq OTP version: 0x%8.8x", val);

val = get_unaligned_le32(skb_pull_data(skb, 4));
p = skb_pull_data(skb, 4);
if (!p)
goto malformed;
val = get_unaligned_le32(p);
bt_dev_dbg(hdev, "Fseq MBX otp version: 0x%8.8x", val);

kfree_skb(skb);
return;

malformed:
bt_dev_dbg(hdev, "Malformed packet received");
kfree_skb(skb);
}
EXPORT_SYMBOL_GPL(btintel_print_fseq_info);

Expand Down
Loading