BEP_667: Introduce Vote Interval to Relax Fast Finality Consensus.#3589
Closed
zlacfzy wants to merge 2 commits intobnb-chain:developfrom
Closed
BEP_667: Introduce Vote Interval to Relax Fast Finality Consensus.#3589zlacfzy wants to merge 2 commits intobnb-chain:developfrom
zlacfzy wants to merge 2 commits intobnb-chain:developfrom
Conversation
zlacfzy
changed the title
zlacfzy
changed the title
zlacfzy
changed the title
NathanBSC
reviewed
Apr 21, 2026
| log.Debug("failed to get BlockInterval when voting") | ||
| } | ||
| voteAssembledTime := time.UnixMilli(int64((curHead.MilliTimestamp() + p.GetAncestorGenerationDepth(curHead)*blockInterval))) | ||
| // BEP-667: votes for curHead will be included in the next voting block, |
Contributor
There was a problem hiding this comment.
so before Pasteur, there will be more chances to refuse to vote?
NathanBSC
reviewed
Apr 21, 2026
| if len(votes) >= quorum { | ||
| targetHeaderParentSnap = snap | ||
| break | ||
| for votingLeft := p.GetAncestorGenerationDepth(header); votingLeft > 0; { |
Contributor
There was a problem hiding this comment.
why need votingLeft?
and we need a comment that: after pasteur enabled, these code can be cleared up
NathanBSC
reviewed
Apr 21, 2026
| ancestor := parent | ||
| ancestorParents := trimParents(parents) | ||
| for range p.GetAncestorGenerationDepth(header) { | ||
| for votingLeft := p.GetAncestorGenerationDepth(header); votingLeft > 0; { |
allformless
reviewed
Apr 22, 2026
| voteInterval := uint64(1) | ||
| if chainConfig.IsPasteur(header.Number, header.Time) { | ||
| voteInterval = pasteurVoteInterval | ||
| } |
Collaborator
There was a problem hiding this comment.
need more handle and comment during transition
Collaborator
|
decide not included in Pasteur, but need for reduce block interval further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/bnb-chain/BEPs/blob/master/BEPs/BEP-667.md
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: