fix: remove old SP key indexes on edit#683
Open
flywukong wants to merge 1 commit into
Open
Conversation
Pull Request ReviewThis PR fixes stale secondary-index handling for storage provider identity rotation in the Cosmos SDK-based SP keeper logic. In Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes stale SP key indexes after
EditStorageProvider.When an SP rotates operational identities such as
seal,gc,approval, orbls, the old secondary indexes were not removed. As a result, retired keys could still resolve to the same SP and be accepted by storage authorization paths.This PR updates
EditStorageProviderto:Note: this PR prevents new stale SP key indexes from being created. Existing stale indexes in chain state should be cleaned by a one-time upgrade migration that prunes secondary indexes whose key no longer matches the current SP identity
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts