Skip to content

refactor FileUpload._copy_file() #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergBobrovsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor FileUpload._copy_file() #1299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bottle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2778,10 +2778,10 @@ def filename(self):

def _copy_file(self, fp, chunk_size=2 ** 16):
read, write, offset = self.file.read, fp.write, self.file.tell()
while 1:
buf = read(chunk_size)
if not buf: break
buf = read(chunk_size)
while buf:
write(buf)
Copy link
Copy Markdown
Contributor

@oz123 oz123 Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement.

buf = read(chunk_size)
self.file.seek(offset)

def save(self, destination, overwrite=False, chunk_size=2 ** 16):
Expand Down