migration: add setting to enable nvidia device plugin#4856
Open
maherthomsi wants to merge 1 commit into
Open
Conversation
maherthomsi
force-pushed
the
nvidia-migrations
branch
7 times, most recently
from
1d1e10c to
0d98e33
Compare
vigh-m
reviewed
Jun 9, 2026
Signed-off-by: Maher Homsi <maherhom@amazon.com>
maherthomsi
force-pushed
the
nvidia-migrations
branch
from
0d98e33 to
8390a92
Compare
jpculp
approved these changes
Jun 9, 2026
piyush-jena
approved these changes
Jun 9, 2026
vigh-m
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds the nvidia-k8s-device-plugin-enabled settings migration.
This migration supports the new
settings.kubelet-device-plugins.nvidia.enabled fieldadded in bottlerocket-settings-sdk#135 and bottlerocket-core-kit#914.enabledfield defaults toNone(treated as enabled), so existing data is compatible.Removes settings.kubelet-device-plugins.nvidia.enabledfrom the datastore so older versions don't encounter an unknown field.Testing done:
cargo testpasses for all workspace crates includingnvidia-k8s-device-plugin-enabledupdog update -i 1.63.0 -r -n- settings preserved (forward no-op confirmed)settings.kubelet-device-plugins.nvidia.enabled=trueon v1.63.0signpost rollback-to-inactive+reboot- enabled key successfully removed by backward migration, all other settings intactTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.