Skip to content

Grant submissions are unreachable: add a grant application path or reject grants in submit explicitly #132

Description

@0xdevcollins

Source: docs/threat-model.md v1.0, DoS.13 (Priority 3, Open).

Problem

submit requires a prior application for Pillar::Bounty | Pillar::Grant (event_ops.rs:573), but apply_to_bounty accepts only Pillar::Bounty (bounty.rs, require_active_bounty). A grant submit therefore always fails with ApplicantNotApplied. Fail-closed, so no security impact, but a dead path that will confuse integrators and auditors.

Options

  • Generalise the application entry point to grants (apply_to_event), or
  • Make submit reject grant events with a dedicated error (grants proceed through owner-driven selection and milestone claims without on-chain submissions).

Done when

The chosen behaviour is tested for all four event types and Appendix A of the threat model is updated.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions