-
Notifications
You must be signed in to change notification settings - Fork 27
fix(events): refuse submit and withdraw after winner selection and track updated_at #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rushikeshgarad2024-dev
wants to merge
6
commits into
boundlessfi:testnet
Choose a base branch
from
rushikeshgarad2024-dev:fix/submit-refuse-after-selection-131
base: testnet
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
03be58a
feat(types): add updated_at field to Submission struct (closes #131)
rushikeshgarad2024-dev 904d7b7
fix(events): refuse submit and withdraw_submission once winner select…
rushikeshgarad2024-dev 290934a
test(hackathon): add tests for updated_at and rejection after winner …
rushikeshgarad2024-dev fa35ebd
fix(types): make updated_at field Option<u64> for backwards compatibi…
rushikeshgarad2024-dev 3618403
fix(events): populate updated_at as Some(timestamp) in Submission
rushikeshgarad2024-dev befb403
test(hackathon): update tests to expect Option<u64> updated_at
rushikeshgarad2024-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contract Lifecycle & State: Persistent state decode breakage in
SubmissionSubmissionis a#[contracttype]persisted inenv.storage().persistent(); adding the newupdated_atfield changes its serialized layout, so any pre-upgrade storedSubmissionvalues may fail to deserialize after upgrade, potentially trapping on reads (e.g.,storage::get_submission) and breaking submit/withdraw flows for existing applicants.Add an explicit storage migration/versioning strategy for existing
Submissionentries (e.g., storeupdated_atseparately, or make itOption<u64>and treatNoneassubmitted_at, or migrate all stored submissions during an upgrade/init path) before deploying this change to an existing network.Fix with MCP
Actions
/almanax ask <question>to ask a follow-up question./almanax dismiss [<reason>]and it won't appear again in future scans./almanax resolve [<reason>]to mark the finding as resolved./almanax severity <level> [<reason>]to override the severity.