This repository was archived by the owner on Mar 12, 2020. It is now read-only.
Adding some features - #22
Open
HanXHX wants to merge 3 commits into
Open
Conversation
|
Looks good to me! I no longer work at Box UK however so I can't test/merge this. Thanks for getting involved though! |
Author
|
OK I understand... Can you give me ownership about this repository or can you define a "true" licence? |
|
I suppose this would still be the canonical repository, perhaps somebody from Box UK could weigh in? If not, feel free to fork :-) @bendavies @h00zf1sh @jenkoian @lukequinnell ? |
Contributor
Contributor
There was a problem hiding this comment.
Maybe leave the default as just '/'
Author
There was a problem hiding this comment.
Yeah it's just an error... I use a sub-uri at work.
Contributor
|
Finally got a chance to have a proper look at this, sorry it took so long. Few minor things, but generally looks good and am happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
There is my pull request. I deleted some useless files (not needed) and i added dynamic columns + suburi management.
Cheers!
Emilien