Skip to content

Fix invalid flag edge case after nargs#458

Merged
brentyi merged 1 commit intomainfrom
brent/20260413_dont_consume_flags_in_nargs
Apr 13, 2026
Merged

Fix invalid flag edge case after nargs#458
brentyi merged 1 commit intomainfrom
brent/20260413_dont_consume_flags_in_nargs

Conversation

@brentyi
Copy link
Copy Markdown
Owner

@brentyi brentyi commented Apr 13, 2026

Fixes #457, thanks @leCapi!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.64%. Comparing base (8e773a4) to head (9c06fa4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          52       52           
  Lines        3984     3984           
=======================================
  Hits         3970     3970           
  Misses         14       14           
Flag Coverage Δ
unittests 99.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brentyi brentyi merged commit 8b67a15 into main Apr 13, 2026
18 checks passed
@brentyi brentyi deleted the brent/20260413_dont_consume_flags_in_nargs branch April 13, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unrecognized option bug since 1.09

1 participant