fix(core): don't apply any score to neighbor for empty responses - #1116
Merged
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1116Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
=========================================
Coverage ? 60.08%
=========================================
Files ? 484
Lines ? 83305
Branches ? 83305
=========================================
Hits ? 50055
Misses ? 30880
Partials ? 2370 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rexagon
force-pushed
the
fix/downrank-strange-peers
branch
from
July 20, 2026 11:26
1c3a4b6 to
7d58b40
Compare
MrWad3r
approved these changes
Jul 20, 2026
Rexagon
force-pushed
the
fix/downrank-strange-peers
branch
3 times, most recently
from
July 22, 2026 15:49
6f3838f to
85b9f24
Compare
0xdeafbeef
approved these changes
Jul 22, 2026
Rexagon
force-pushed
the
fix/downrank-strange-peers
branch
from
July 23, 2026 10:31
85b9f24 to
bac5747
Compare
Rexagon
force-pushed
the
fix/downrank-strange-peers
branch
from
July 23, 2026 10:50
bac5747 to
dd5e79e
Compare
Rexagon
enabled auto-merge
July 23, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an
ignorepath for query response. It still affects the roundtrip but it doesn't change the score for this neighbor. (And there is also a maximum of16points for "good" roundtrips so it will not be better than other "answering" peers).Fixes #1115