Skip to content

fix(core): don't apply any score to neighbor for empty responses - #1116

Merged
Rexagon merged 2 commits into
masterfrom
fix/downrank-strange-peers
Jul 23, 2026
Merged

fix(core): don't apply any score to neighbor for empty responses#1116
Rexagon merged 2 commits into
masterfrom
fix/downrank-strange-peers

Conversation

@Rexagon

@Rexagon Rexagon commented Jul 16, 2026

Copy link
Copy Markdown
Member

Added an ignore path for query response. It still affects the roundtrip but it doesn't change the score for this neighbor. (And there is also a maximum of 16 points for "good" roundtrips so it will not be better than other "answering" peers).

Fixes #1115

@Rexagon
Rexagon requested review from 0xdeafbeef and MrWad3r July 16, 2026 11:56
@github-actions

Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1116

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1116
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1116 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.24521% with 62 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@b62a91a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/src/blockchain_rpc/client.rs 63.29% 28 Missing and 1 partial ⚠️
core/src/overlay_client/mod.rs 74.62% 15 Missing and 2 partials ⚠️
core/src/overlay_client/neighbours.rs 85.00% 12 Missing and 3 partials ⚠️
core/src/block_strider/starter/cold_boot.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1116   +/-   ##
=========================================
  Coverage          ?   60.08%           
=========================================
  Files             ?      484           
  Lines             ?    83305           
  Branches          ?    83305           
=========================================
  Hits              ?    50055           
  Misses            ?    30880           
  Partials          ?     2370           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rexagon
Rexagon force-pushed the fix/downrank-strange-peers branch from 1c3a4b6 to 7d58b40 Compare July 20, 2026 11:26
@Rexagon
Rexagon force-pushed the fix/downrank-strange-peers branch 3 times, most recently from 6f3838f to 85b9f24 Compare July 22, 2026 15:49
@Rexagon
Rexagon force-pushed the fix/downrank-strange-peers branch from 85b9f24 to bac5747 Compare July 23, 2026 10:31
@Rexagon
Rexagon force-pushed the fix/downrank-strange-peers branch from bac5747 to dd5e79e Compare July 23, 2026 10:50
@Rexagon
Rexagon enabled auto-merge July 23, 2026 10:53
@Rexagon
Rexagon added this pull request to the merge queue Jul 23, 2026
Merged via the queue into master with commit 4038c33 Jul 23, 2026
23 checks passed
@Rexagon
Rexagon deleted the fix/downrank-strange-peers branch July 23, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downrank peers that return None for block requests

3 participants