OpenMP solvers#110
Conversation
asmelko
left a comment
asmelko
left a comment
There was a problem hiding this comment.
I see you updated vcpkg submodule. was there any concrete reason for that?
asmelko
left a comment
asmelko
left a comment
There was a problem hiding this comment.
please, copy reactions-diffusion/biofvm/kernels/.clang-tidy file into kernels directory so that clang tidy does not complain about congnitive complexity
| class random | ||
| { | ||
| public: | ||
| static random& instance(); |
There was a problem hiding this comment.
There is no need for the instance method when all the other methods are static
|
|
||
| namespace physicore { | ||
|
|
||
| class random |
There was a problem hiding this comment.
move random.h and .cpp to mechanics/physicell -> its used only there so far
if we put it into common module, randomness implementation should correctly support all possible kernels (now it supports only openmp and single core) so that it could be called from within them
|
Please look into the Sonarqube code coverage and cover missing lines with some meaningful tests. |
|
|
|
|
We should add motility and basement membrane tests |
3 participants
Includes #73. Significant change to discuss is that I had to move mesh to common to include mechanics.