Add basic benchmarking workflow, create benchmark/ folder with bench script#299
Draft
starsfordummies wants to merge 1 commit into
Draft
Add basic benchmarking workflow, create benchmark/ folder with bench script#299starsfordummies wants to merge 1 commit into
starsfordummies wants to merge 1 commit into
Conversation
Collaborator
|
yeah, don't worry. we can later add it to the let's start by adding some benchmarks. @starsfordummies @jofrevalles @Todorbsc what do you think about benchmarking the following?
we can benchmark more stuff in the future, but let's start with the following which are key to us right now @starsfordummies i'm changing this to a draft PR because it's not yet ready to merge |
Member
|
Hey @mofeing @starsfordummies @Todorbsc, I will design some benchmarks for this and let you know. Is this okay? |
Collaborator
|
@jofrevalles that sounds great! i would say that feel free to push to this PR so we can see the result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally this should create some benchmark data in
dev/bench/data.jsin thegh-pagesbranch, as well as an accompanying index.html - I have an updated index.html as well but I don't know how to make it such that the pr puts it in the gh-pages folder...the html file to put in gh-pages should be https://github.com/starsfordummies/testing_livebench/blob/gh-pages/dev/bench/index3.html
More info on the thing in https://github.com/marketplace/actions/continuous-benchmark