Handle vendored descriptor.proto gracefully#4478
Merged
emcfarlane merged 8 commits intomainfrom Apr 17, 2026
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Contributor
Author
doriable
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upgrade protocompile to handle vendored descriptor.proto.
Fix resolver construction when compiled files include a vendored
descriptor.proto. The buf descriptor extension (field536000000on FileDescriptorSet) fails protodesc validation when FileDescriptorSet is resolved from the vendored file rather than left as a placeholder, because it has no declared extension ranges. Skip prepending the buf descriptor proto whendescriptor.protois already in the compiled output.Depends on bufbuild/protocompile#710