fix: update attachment URLs for new server route layout#282
Merged
Conversation
Companion to buggregator/server#336. The server now namespaces attachment endpoints as /api/{module}/attachments/{eventUuid}[/{uuid}] so they no longer collide with module-specific 4-segment routes like /api/smtp/message/{uuid}/raw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the client to call attachments through
/api/{module}/attachments/{eventUuid}[/{uuid}].Why
Companion to buggregator/server#336. The server's previous attachment layout (
/api/{module}/{eventUuid}/attachments/{uuid}) collided with the new SMTP message routes and made the server panic at startup. The server PR nests attachments under a literalattachmentssegment to break the conflict; this PR keeps the frontend in sync.Testing
Manual: open an SMTP event in the UI and confirm the attachments list and download links work against a server built with the companion PR.