Fix profiler module: metrics calculation, flame chart parameterization, and cache cleanup#311
Merged
Merged
Conversation
Member
butschster
commented
Mar 26, 2026
butschster
commented
- Fix overallTotals bug in FindTopFunctionsByUuidHandler: aggregate metrics for same callee from different callers instead of only counting first occurrence
- Fix diff calculation in CalculateDiffsBetweenEdges: compute correct exclusive metrics (inclusive minus children sum) and add missing d_ct
- Add ct to percentage calculation in PrepareEdges (p_ct was always 0)
- Fix batch counter off-by-one in StoreProfileHandler
- Extract duplicated splitName into shared EdgeNameSplitter utility
- Parameterize flame chart metric (was hardcoded to wt): add FlameChartRequest filter, pass metric from frontend, include metric in cache file key
- Add flame chart cache invalidation on profile deletion
…n, and cache cleanup - Fix overallTotals bug in FindTopFunctionsByUuidHandler: aggregate metrics for same callee from different callers instead of only counting first occurrence - Fix diff calculation in CalculateDiffsBetweenEdges: compute correct exclusive metrics (inclusive minus children sum) and add missing d_ct - Add ct to percentage calculation in PrepareEdges (p_ct was always 0) - Fix batch counter off-by-one in StoreProfileHandler - Extract duplicated splitName into shared EdgeNameSplitter utility - Parameterize flame chart metric (was hardcoded to wt): add FlameChartRequest filter, pass metric from frontend, include metric in cache file key - Add flame chart cache invalidation on profile deletion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
butschster
force-pushed
the
fix/profiler-module-improvements
branch
from
5c58e34 to
c2dccb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.