Fix GitHub token leak in Docker image builds#313
Merged
Conversation
The GH_TOKEN was passed as a build-arg and stored via ENV in image layers, making it visible through docker history/inspect to anyone pulling the published image. Switch to BuildKit secrets: - Dockerfile: use RUN --mount=type=secret,id=gh_token so the token is only available in memory during the RUN command and never persisted in any layer - GitHub Actions workflows: pass token via secrets instead of build-args - docker-compose.yaml: use secrets definition sourced from environment variable Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GH_TOKENwas passed as--build-argand stored viaENVin image layers, making it visible throughdocker history/docker inspectto anyone pulling the published imageRUN --mount=type=secret): the token is mounted in memory only during theRUNcommand and never persisted in any image layerdocker-image.yml,docker-dev-image.yml) to pass token viasecrets:instead ofbuild-args:docker-compose.yamlto usesecretsdefinition sourced fromGH_TOKENenvironment variableTest plan
docker historyon the built image and confirm no token is visibleGH_TOKEN=... docker compose buildstill works🤖 Generated with Claude Code