Skip to content

fix: set workerName, instanceName for worker profile and pipeline cha… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonschroeder-sfdc wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: set workerName, instanceName for worker profile and pipeline cha… #19

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
292af29
fix: set workerName, instanceName for worker profile and pipeline cha…
jasonschroeder-sfdc Oct 13, 2025
25e8d98
Prevent concurrent app.Ops read/write
werkt Nov 26, 2025
bca7ef5
fix(crasher): avoid crashing when ExecutionOperationMetadata is not p…
jasonschroeder-sfdc Oct 16, 2025
515378b
chore(deps): bump buildfarm to v2.16.0
jasonschroeder-sfdc Mar 23, 2026
81697ee
Contributor guide and pre-commit configuration (optional)
jasonschroeder-sfdc Oct 9, 2025
18b461c
build: remove non-existent target
jasonschroeder-sfdc Oct 13, 2025
b1f2d10
ci: build everything
jasonschroeder-sfdc Oct 13, 2025
19ecd4d
refactor: use App.Instance instead of hard-coded "shard" instance name
jasonschroeder-sfdc Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions view/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,12 +554,18 @@ func pausedStyle(p bool) ui.Style {
func (v *worker) Update() {
conn := v.a.GetWorkerConn(v.w, v.a.CA)
workerProfile := bfpb.NewWorkerProfileClient(conn)
profile, err := workerProfile.GetWorkerProfile(context.Background(), &bfpb.WorkerProfileRequest{})
profile, err := workerProfile.GetWorkerProfile(context.Background(), &bfpb.WorkerProfileRequest{
InstanceName: "shard",
WorkerName: v.w,
})
if err == nil {
v.profile = profile
}
c := bfpb.NewWorkerControlClient(conn)
r, err := c.PipelineChange(context.Background(), &bfpb.WorkerPipelineChangeRequest{})
r, err := c.PipelineChange(context.Background(), &bfpb.WorkerPipelineChangeRequest{
InstanceName: "shard",

@werkt werkt Nov 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instance name is set in the app context: https://github.com/buildfarm/bf-client/blob/master/client/app.go#L19

WorkerName: v.w,
})
if err != nil {
panic(err)
}
Expand Down