Skip to content

chore(docker): generate docker images on tag/push#41

Open
Falci wants to merge 4 commits into
bumi:masterfrom
Falci:docker1
Open

chore(docker): generate docker images on tag/push#41
Falci wants to merge 4 commits into
bumi:masterfrom
Falci:docker1

Conversation

@Falci
Copy link
Copy Markdown

@Falci Falci commented Jul 26, 2022

Every merge to master will generate a lnme:edge image.
Every tag will:

  • update lnme:latest
  • generate a new lnme:<tag>

#39

@bumi
Copy link
Copy Markdown
Owner

bumi commented Aug 1, 2022

thanks @Falci for the PR!
@AaronDewes you had done this before. any comments?

Copy link
Copy Markdown
Contributor

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, but looks good to me otherwise

Comment thread .github/workflows/docker.yml Outdated
Comment thread .github/workflows/docker.yml Outdated
Falci and others added 2 commits August 7, 2022 10:12
Co-authored-by: Aaron Dewes <aaron.dewes@protonmail.com>
@bumi
Copy link
Copy Markdown
Owner

bumi commented Aug 11, 2022

thanks @AaronDewes for the feedback!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants