Skip to content

[C#] Add support for the ping pong test, bring support for futures that return strings, i.e. types returned via pointers.#1606

Merged
yowl merged 3 commits intobytecodealliance:mainfrom
yowl:csharp-ping-pong
May 2, 2026
Merged

[C#] Add support for the ping pong test, bring support for futures that return strings, i.e. types returned via pointers.#1606
yowl merged 3 commits intobytecodealliance:mainfrom
yowl:csharp-ping-pong

Conversation

@yowl
Copy link
Copy Markdown
Collaborator

@yowl yowl commented Apr 28, 2026

As per the title, this PR adds more support to the C# wit-bindgen to get the ping-pong test to pass. As part of this I've:

  • Added more things to the VTable: size, alignment, lower and lift.
  • Added support for lifting and lowering, tested for strings only.
  • Removed ICancelableRead and ICancelableWrite and replaced with IVTable
  • Removed the FreeBuffer method and replaced with cleanup actions

Requires supporting futures that return strings.
@yowl yowl force-pushed the csharp-ping-pong branch from f95033f to 7f6a5b1 Compare April 29, 2026 00:21
@yowl yowl changed the title [C#] WIP Csharp ping pong [C#] Add support for the ping pong test, bring support for futures that return strings, i.e. types returned via pointers. Apr 29, 2026
@yowl yowl requested review from dicej and silesmo April 29, 2026 01:27
@yowl yowl marked this pull request as ready for review April 29, 2026 01:27
Copy link
Copy Markdown
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuing to push this forward!

Comment thread crates/csharp/src/AsyncSupport.cs Outdated
Comment thread crates/csharp/src/AsyncSupport.cs Outdated
Comment thread crates/csharp/src/AsyncSupport.cs Outdated
Comment thread crates/csharp/src/function.rs
Comment thread crates/csharp/src/interface.rs Outdated
Comment thread crates/csharp/src/interface.rs
@yowl yowl added this pull request to the merge queue May 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 2, 2026
@yowl
Copy link
Copy Markdown
Collaborator Author

yowl commented May 2, 2026

going to try again as looked like connectivity issue

@yowl yowl added this pull request to the merge queue May 2, 2026
Merged via the queue into bytecodealliance:main with commit 6f489db May 2, 2026
29 checks passed
@yowl yowl deleted the csharp-ping-pong branch May 2, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants