Raise an error if timeline values are duplicated#129
Open
oplantalech wants to merge 1 commit into
Open
Conversation
oplantalech
force-pushed
the
validate_timeline_duplications
branch
from
97c3807 to
0976fcc
Compare
oplantalech
force-pushed
the
validate_timeline_duplications
branch
from
0976fcc to
3980dc2
Compare
Contributor
|
This PR seems to cover full record duplication. |
Contributor
Author
|
@sheridancbio I think this highlights a need for a broader discussion on how we handle timeline duplications. My PR targets full record duplication to keep the logic lean, but since #108 takes a case-by-case approach, we’re at a crossroads. Do we prefer a catch-all validation, or the granular control seen in #108? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #128
Raise an error if timeline entries are duplicated