feat: wire 👍/👎 feedback to Langfuse Scores (#144)#154
Merged
Conversation
- TurnTrace exposes trace_id via get_current_trace_id() after root span opens - Done event carries trace_id; agent emits it - ChatMessageRow has nullable langfuse_trace_id (alembic migration) - FakeLangfuseClient mocks get_current_trace_id + records create_score calls
- chat route persists Done.trace_id on the assistant message row - PUT /feedback forwards rating to Langfuse create_score (name=user_feedback, value=1.0/0.0, deterministic score_id for upsert semantics) - DELETE /feedback does not touch Langfuse — history preserved on the dashboard - Forward is best-effort: failures logged, never bubble up to the client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TurnTraceexposestrace_id(captured viaget_current_trace_id()after the root span opens)Doneevent carriestrace_id; agent emits itchat_messages.langfuse_trace_idcolumn (alembic migration092e2aa153ce); set when persisting the assistant messagePUT /feedbackforwards rating tocreate_score(name="user_feedback", value=1.0/0.0, data_type="NUMERIC", trace_id=..., score_id="feedback-{user_sub}-{message_id}")— only whentrace_idis presentscore_idso re-clicks update in place (assuming Langfuse upserts; duplicates are prefix-greppable for cleanup if not)DELETE /feedbackleaves Langfuse history alone (dashboard retains the previous rating)Closes #144.
Test plan
name=user_feedback,value=1.0