feat(zarr-adapter): recognize 'gene' as a gene-symbol column candidate#162
Merged
Conversation
egfr_all_cells.zarr stores symbols in a column literally named 'gene' rather than the common 'feature_name' / 'gene_symbol' conventions. Adds 'gene' at the END of the priority list so datasets with a canonical column still win. Per-dataset overrides for unusual schemas are tracked in a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `gene` (the literal column name) to `GENE_SYMBOL_COLUMNS` so datasets like `egfr_all_cells.zarr` — which store symbols in a column named `gene` rather than the common `feature_name`/`gene_symbol` conventions — auto-resolve gene symbols correctly. Without this the chat agent's tools return raw Ensembl IDs and have to guess symbols from training data.
`gene` is the most ambiguous candidate (the name could in theory mean other things), so it sits at the end of the priority list. A dataset that has both `feature_name` and `gene` still picks `feature_name`.
Per-dataset overrides for truly unusual schemas are tracked separately.
Test plan