Skip to content

[4.x] Add support for multiple attribute lines to Commenting.FunctionComment #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scribblemaniac wants to merge 1 commit into
base: 4.x
Choose a base branch
from
+27 −1
Open

[4.x] Add support for multiple attribute lines to Commenting.FunctionComment #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CakePHP/Sniffs/Commenting/FunctionCommentSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public function process(File $phpcsFile, $stackPtr)
&& $tokens[$commentEnd]['code'] !== T_COMMENT
) {
$previous = $commentEnd;
if (
while (
$tokens[$commentEnd]['code'] === T_ATTRIBUTE_END
|| $tokens[$commentEnd]['code'] === T_ATTRIBUTE
) {
Expand Down
13 changes: 13 additions & 0 deletions CakePHP/Tests/Commenting/FunctionCommentUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,4 +239,17 @@ class Foo
public function returnWillChange($param, $otherParam)
{
}

/**
* Some sentence.
*
* @param int $param Some Param.
* @param bool $otherParam Some Other Param.
* @return string Something.
*/
#[ReturnTypeWillChange]
#[NoDiscard]
public function withMultipleAttributes($param, $otherParam)
{
}
}
13 changes: 13 additions & 0 deletions CakePHP/Tests/Commenting/FunctionCommentUnitTest.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,4 +239,17 @@ class Foo
public function returnWillChange($param, $otherParam)
{
}

/**
* Some sentence.
*
* @param int $param Some Param.
* @param bool $otherParam Some Other Param.
* @return string Something.
*/
#[ReturnTypeWillChange]
#[NoDiscard]
public function withMultipleAttributes($param, $otherParam)
{
}
}
Loading