Conversation
Update the additional-error-responses info.description block and the r4.3 Design Guide link to r4.4.
…chemas Replace deprecated Generic<status> responses with the r4.4 catalogue where the code set matches exactly, or a local response with the same codes referencing the shared examples where it doesn't. Reuse the new common SingleIpv4Address/SingleIpv6Address and Sink schemas in place of local duplicates.
hdamker
requested review from
benhepworth,
eric-murray and
jlurien
as code owners
September 15, 2026 11:54
Collaborator
Author
|
@camaraproject/quality-on-demand_codeowners please let me know if there are any changes needed to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
Brings
quality-on-demandandqos-provisioninginto line with CAMARA Commonalities 0.9.0 (r4.4). Backward-compatible with the released1.1.0/0.3.0: no response code set is narrowed and no existing errorcodevalue is renamed.Highlights:
x-camara-commonalities: 0.9.0in both specs and re-copy the driftedadditional-error-responsesinfo.descriptionblock.Generic<status>responses onto the r4.4 catalogue:$refthe catalogue entry directly where its code set matches exactly (BadRequest400,BadRequestWithRange400,Unauthenticated401,PermissionDenied403,NotFound404,DeviceIdentifier422,SinkGone410); where it would narrow the declared set, keep a local response with the same codes and$refthe matching shared examples instead (a combined 404 for the device-identified operations, a combined 429 withQUOTA_EXCEEDED).CAMARA_common.yaml/CAMARA_event_common.yamlexample pools wherever a local response stays.SingleIpv4Address/SingleIpv6Addressschemas in place of local duplicates (resolves quality-on-demand.yaml: replace local SingleIpv4Addr/SingleIpv6Addr with common $ref (after Commonalities r4.4) #585), and the new commonSinkschema in place of the local inline definition..featuretest-definition OAS pointers to the#/prefix used by the r4.4 test template.Not carried in this PR, because both would require a new major version: adding
422 EVENT_NOTIFICATIONS_NOT_SUPPORTEDfor the optionalsinkon session/assignment creation, and replacing the deprecated409 CONFLICTwithINCOMPATIBLE_STATE.Which issue(s) this PR fixes:
Fixes #618
Special notes for reviewers:
404,429) stay local with their full existing code set rather than adopting the narrower catalogue entry.INVALID_CREDENTIAL's message now says "Only Access token or Private key JWT are supported" (was stale from before Align quality-on-demand API and tests with Commonalities 0.8.0 (r4.3) #579 addedPRIVATE_KEY_JWT), andINVALID_TOKEN's message now describes an invalid/expired token rather than "Only bearer token is supported". Only thecodeis contractual; the message text is not.qos-provisioning's localsinkschema's description already matched the new commonSinkschema's description verbatim;quality-on-demand's kept its more specific session-termination wording via the siblingdescriptionnext to theallOf.Changelog input
Additional documentation
This section can be blank.