Add timeout and response size limit for HTTP fetches#86
Merged
Conversation
Use a package-level http.Client with a 10-second timeout instead of the default client, and cap response bodies at 10 MiB with io.LimitReader. This prevents embedmd from hanging indefinitely on slow servers and from exhausting memory on large responses. Closes #81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.Get(no timeout) with a package-levelhttp.Clientset to a 10-second timeout, preventing the process from hanging on slow or unresponsive servers.io.LimitReaderat 10 MiB so a large response cannot exhaust memory.embedmd/content_test.gowith three tests usinghttptest.NewServer:Not Found; expect a non-nil error.Test plan
TestFetchHTTPTimeout— process returns an error when the server stallsTestFetchHTTPSizeLimit— response is capped at exactly 10 MiBTestFetchHTTPNotFound— non-200 status returns an errorgo test ./...)Closes #81