Skip to content

Use 0644 instead of 0666 for file mode in openFile #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
campoy wants to merge 3 commits into from
Closed

Use 0644 instead of 0666 for file mode in openFile #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4455a8c
Use 0644 instead of 0666 for file mode in openFile
Apr 11, 2026
a95c0e5
Preserve original file permissions when rewriting
Apr 11, 2026
5883771
Use mode 0 in openFile to clarify permissions are not set
Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ type file interface {

// replaced by testing functions.
var openFile = func(name string) (file, error) {
return os.OpenFile(name, os.O_RDWR, 0666)
// The permission bits (third argument) are only used when O_CREATE is set.
// Since we only open existing files, 0 is passed to make that clear.
return os.OpenFile(name, os.O_RDWR, 0)
}

func processFile(path string, rewrite, doDiff bool) (foundDiff bool, err error) {
Expand Down
3 changes: 1 addition & 2 deletions main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to writing, software distributed
// under the License is distributed on a "AS IS" BASIS, WITHOUT WARRANTIES OR
// under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
// CONDITIONS OF ANY KIND, either express or implied.
//
// See the License for the specific language governing permissions and
Expand Down Expand Up @@ -120,7 +120,6 @@ func TestEmbedFiles(t *testing.T) {
if got := f.buf.String(); tt.out != got {
t.Errorf("case [%s]: expected output \n%q; got\n%q", tt.name, tt.out, got)
}

}
}

Expand Down
Loading