Allow setting a custom output file which will contain all types, fixes #9#24
Open
wwsean08 wants to merge 2 commits intocampoy:masterfrom
Open
Allow setting a custom output file which will contain all types, fixes #9#24wwsean08 wants to merge 2 commits intocampoy:masterfrom
wwsean08 wants to merge 2 commits intocampoy:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! That being said it's not letting me put the email address i use for git commits in as an alternative saying it's associated with another account |
|
CLAs look good, thanks! |
Author
|
@campoy any chance you can look at this, just noticed this has been sitting around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new flag to set a custom output file will allow you to set a single file for all the code to go into which essentially works around the problem in issue #9, one other possible solution is to clear the buffer at the end of the loop but it all depends on how you want this program to work (I can see reasons both individual files or a file for each one).