Cleanup nsenter invocation - #234
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes Python nsenter command construction and uses explicit host paths for snap management.
Changes:
- Reuses
NSENTER_PREFIXfor host command execution. - Runs
nvidia-smiin the host mount namespace. - Uses
/usr/bin/snapexplicitly when managing sosreport.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/bugit_v2/dut_utils/log_collectors.py |
Replaces duplicated nsenter arguments with the shared prefix. |
src/bugit_v2/dut_utils/info_getters.py |
Executes nvidia-smi through the host namespace. |
snap/local/scripts/run_sos.sh |
Uses the host’s explicit snap executable. |
snap/hooks/install |
Uses the host’s explicit snap executable during installation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.