Skip to content

chore: delete some dead code #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bepri wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: delete some dead code #2682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions charmcraft/application/commands/lifecycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import craft_cli
from craft_application.commands import lifecycle
from craft_application.util import is_managed_mode
from craft_cli import CraftError
from typing_extensions import override

from charmcraft import models, utils
Expand Down Expand Up @@ -108,21 +107,6 @@ def _fill_parser(self, parser: argparse.ArgumentParser) -> None:
def _should_add_shell_args() -> bool:
return True

def _validate_bases_indices(self, bases_indices):
"""Validate that bases index is valid."""
if bases_indices is None:
return

project = cast(models.Charm, self._services.project)

msg = "Bases index '{}' is invalid (must be >= 0 and fit in configured bases)."
len_configured_bases = len(project.bases)
for bases_index in bases_indices:
if bases_index < 0:
raise CraftError(msg.format(bases_index))
if bases_index >= len_configured_bases:
raise CraftError(msg.format(bases_index))

def _update_charm_libs(self) -> None:
"""Update charm libs attached to the project."""
craft_cli.emit.progress(
Expand Down
Loading