chore(26.04): migrate libtcnative-1 to libtcnative-2 - #1053
Conversation
31b7702 to
88f7d47
Compare
|
Diff of dependencies: |
|
Removed slices check fails due to the migration |
Test CoverageAverage Total Coverage: 100.00% Arch: aarch64Coverage: 100.00%
|
alesancor1
left a comment
alesancor1
left a comment
There was a problem hiding this comment.
This is a regression, libtcnative-1 still exists in the archives, so I don't think it should be removed.
My suggestion is to create a new SDF for libtcnative-2 and leave the previous one unchanged.
In terms of contents, the SDF LGTM 👍
alesancor1
left a comment
alesancor1
left a comment
There was a problem hiding this comment.
All good content-wise, just create a new test for libtcnative-2 and should be good to go! 👍
lczyk
added
ready to merge
|
this is FPed in #1051 but that is a PR with real changes landing in 26.10. any real changes to 26.10 are currently hard-blocked by lack of chisel support (canonical/chisel#306). hence i've done a cherry-pick forward port here: #1121 @cjdcordeiro marking this + its FP as ready to merge for you since i believe you can just merge these two |
|
merging this one but leaving it's FP open, due to the comment from @lczyk above (no rush either) |
|
@cjdcordeiro can you also merge the cherrypick PR too (#1121) to keep 26.10 in sync? #1051 can then just be rebased on top of 26.10 |
5 participants
Proposed changes
Due to SRU https://bugs.launchpad.net/ubuntu/+source/tomcat-native/+bug/2155817 the libtcnative-1 migrates to libtcnative-2.
Update resolute slice definitions.
Related issues/PRs
also included in #1051
Forward porting
Checklist
Additional Context