fix(26.04): util-linux no longer needs liblastlog - #1147
Open
cjdcordeiro wants to merge 2 commits into
Open
Conversation
Test CoverageAverage Total Coverage: 87.50% Arch: aarch64Coverage: 87.50%
|
|
Diff of dependencies: slices/util-linux.yaml@@ -1,3 +1,4 @@
+base-files
libblkid1
libc6
libcap-ng0 |
The login slice ships only sulogin, whose DT_NEEDED is libc6, libcrypt1 and libselinux1 on every supported architecture. libsmartcols1 and libsystemd0 were only ever required by lslogins, which moved to util-linux-extra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removed unneeded dependency from
util-linux_login.IMPORTANT NOTE: this is an interesting case where the opening of a new release carried a change that cause orphaned dependencies. In #662, @lengau introduced a missing dependency to
util-linux, that was needed for thelsloginsbinary.In 26.04, that binary is no longer in the pkg and consequently no longer in the
util-linux_loginslice. However, theliblastlog2-2is left over from #662, and is getting unnecessarily installed. That's not good, cause it goes against what we try to do with Chisel -> remove everything that is unnecessaryI noticed this because
liblastlog2-2brings in sqlite3 libs too, which completely caught me off guard.So what's the takeaway? We're doing a good job at detecting and testing dependencies that are missing, and we don't do enough checks to ensure that we are not shipping unnecessary.
lsloginswas removed in https://github.com/canonical/chisel-releases/pull/857/changes#diff-19d63239e73ac43045433aa7c62758e215be4782ad63accaec2435ddaf8254d0L156. The CI that list the dependency diff did NOT run in #857, unfortunately. That would have (hopefully) said that there was an unnecessary dependency. BUT, even with that, it would have just been an informative comment, while IMO this should've been a CI error. @lczyk can you pls ACK, weigh in, and if agreeing, create a candidate roadmap item for us to tackle this in future releases?Related issues/PRs
#662
Forward porting
#1146
Checklist