Skip to content

Add some helper tools for viewing saved summaries - #744

Draft
dosaboy wants to merge 1 commit into
canonical:mainfrom
dosaboy:add-summary-helpers
Draft

Add some helper tools for viewing saved summaries#744
dosaboy wants to merge 1 commit into
canonical:mainfrom
dosaboy:add-summary-helpers

Conversation

@dosaboy

@dosaboy dosaboy commented Oct 9, 2023

Copy link
Copy Markdown
Member

No description provided.

@dosaboy

dosaboy commented Oct 9, 2023

Copy link
Copy Markdown
Member Author

@nicolasbock id like to hook this up to the bash autocomplete stuff we added in

@nicolasbock

Copy link
Copy Markdown
Contributor

Yes that sounds good @dosaboy . Do you want me to follow up with a PR on the bash completion scripts after you merge this one?

@nicolasbock

Copy link
Copy Markdown
Contributor

@dosaboy

dosaboy commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

We need to also review https://code.launchpad.net/~nicolasbock/ubuntu/+source/daily-build/+git/daily-build/+merge/447457 @dosaboy

ack i totally missed that one

@dosaboy

dosaboy commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

We need to also review https://code.launchpad.net/~nicolasbock/ubuntu/+source/daily-build/+git/daily-build/+merge/447457 @dosaboy

ack i totally missed that one

merged.

Comment thread tools/summary/view.py Outdated

PLUGIN_NAMES = ['juju', 'mysql', 'openstack', 'openvswitch', 'system',
'maas', 'kernel', 'kubernetes', 'rabbitmq', 'sosreport',
'storage', 'vault', 'pacemaker']

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing lxd.

Also, hotsos/client.py has a similar list, maybe we can just use that?

Comment thread tools/summary/view.py Outdated
_has_potential_issues.update(
s[plugin]['potential-issues'])

# print("enabled: {}".format(', '.join(sorted(_enabled))))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: debug?

@dosaboy

dosaboy commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

thanks for reviews, im gonna put this back to WIP as it needs some changes

@dosaboy
dosaboy marked this pull request as draft October 10, 2023 17:16
@nicolasbock

Copy link
Copy Markdown
Contributor

It would be nice there was some documentation for what those scripts are doing.

@dosaboy
dosaboy force-pushed the add-summary-helpers branch from 5fda435 to 875ab93 Compare March 28, 2024 09:32
@dosaboy
dosaboy force-pushed the add-summary-helpers branch 2 times, most recently from b59c09f to 51ed204 Compare January 29, 2025 17:04
@dosaboy
dosaboy force-pushed the add-summary-helpers branch from 51ed204 to d9011ef Compare March 3, 2025 12:09
Specifically adds two scripts; one to diff between two
summary files or directories and another to less a set
of summaries.
@dosaboy
dosaboy force-pushed the add-summary-helpers branch from d9011ef to 4913ab9 Compare March 10, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants