cli:apply: skip apply rename when predictable interface names disabled#544
Open
jinkkkang wants to merge 1 commit intocanonical:mainfrom
Open
cli:apply: skip apply rename when predictable interface names disabled#544jinkkkang wants to merge 1 commit intocanonical:mainfrom
jinkkkang wants to merge 1 commit intocanonical:mainfrom
Conversation
Author
|
@slyon Is the converage test failure as expected? I found that the original main branch converage test also failed |
Author
|
@slyon can you help review the code? This modification is helpful in environments where predictable interface names is disabled,the udevd will not rename interface, skip it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip apply udev rules rename when predictable interface names disabled
devices_after_udev = utils.get_interfaces()will be useless whenchangesis empty, add a checkChecklist
make checksuccessfully.make check-coverage).