Skip to content

cli:apply: skip apply rename when predictable interface names disabled#544

Open
jinkkkang wants to merge 1 commit intocanonical:mainfrom
jinkkkang:jinkangkang/skip_rename_when_predictable_disable
Open

cli:apply: skip apply rename when predictable interface names disabled#544
jinkkkang wants to merge 1 commit intocanonical:mainfrom
jinkkkang:jinkangkang/skip_rename_when_predictable_disable

Conversation

@jinkkkang
Copy link
Copy Markdown

@jinkkkang jinkkkang commented Feb 26, 2025

skip apply udev rules rename when predictable interface names disabled

  • skip net_setup_link when predictable interface names disabled
  • devices_after_udev = utils.get_interfaces() will be useless when changes is empty, add a check

Checklist

  • Runs make check successfully.
  • Retains code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@jinkkkang jinkkkang changed the title [WIP]cli:apply: skip apply rename when predictable interface names disabled cli:apply: skip apply rename when predictable interface names disabled Feb 26, 2025
@slyon slyon added the community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. label Feb 27, 2025
@jinkkkang
Copy link
Copy Markdown
Author

@slyon Is the converage test failure as expected? I found that the original main branch converage test also failed

@jinkkkang
Copy link
Copy Markdown
Author

@slyon can you help review the code? This modification is helpful in environments where predictable interface names is disabled,the udevd will not rename interface, skip it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants